Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metadata] do not rethrow postpone when streaming metadata is not enabled #75887

Merged
merged 7 commits into from
Feb 11, 2025
Merged

[metadata] do not rethrow postpone when streaming metadata is not enabled #75887

merged 7 commits into from
Feb 11, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 11, 2025 •
edited
Loading

What

We should not throw the postpone error in metadata resolving when streaming metadata is not enabled.

Why

The suspense boundary of streaming metadata can catch the postpone error and render the fallback, but in blocking metadata world we should just swallow it otherwise it will send empty fallback shell

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 11, 2025
@ijjk
Copy link
Member

ijjk commented Feb 11, 2025 •
edited
Loading

Failing test suites

Commit: 5e54947

pnpm test-start test/e2e/app-dir/app-routes-subrequests/app-routes-subrequests.test.ts

  • app-routes-subrequests > shortcuts after 5 subrequests
Expand output

● app-routes-subrequests › shortcuts after 5 subrequests

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 11, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/streaming-cond Change
buildDuration 19.4s 16.7s N/A
buildDurationCached 15.7s 13.3s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +488 B
nextStartRea..uration (ms) 441ms 434ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/streaming-cond Change
5306-HASH.js gzip 54.3 kB 54.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/streaming-cond Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/streaming-cond Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/streaming-cond Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/streaming-cond Change
index.html gzip 524 B 523 B N/A
link.html gzip 540 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 520 B 520 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/streaming-cond Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js fix/streaming-cond Change
middleware-b..fest.js gzip 676 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js fix/streaming-cond Change
app-page-exp...dev.js gzip 395 kB 395 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 382 kB 382 kB ✓
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.9 kB 40.9 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.7 kB 60.7 kB ✓
Overall change 1.67 MB 1.67 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/streaming-cond Change
0.pack gzip 2.11 MB 2.11 MB ⚠️ +2.52 kB
index.pack gzip 76.1 kB 75.4 kB N/A
Overall change 2.11 MB 2.11 MB ⚠️ +2.52 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 5e54947

@ijjk ijjk added the tests label Feb 11, 2025
@huozhi huozhi changed the title do not throw postpone error when streaming metadata is not enabled [metadata] do not rethrow postpone when streaming metadata is not enabled Feb 11, 2025
@huozhi huozhi requested a review from ztanner February 11, 2025 00:26
@huozhi huozhi marked this pull request as ready for review February 11, 2025 00:26
@huozhi huozhi merged commit 4734763 into canary Feb 11, 2025
124 of 126 checks passed
@huozhi huozhi deleted the fix/streaming-cond branch February 11, 2025 02:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ztanner ztanner ztanner approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @ztanner